netdev - Re: [PATCH net-next] enic: add support for set/get rss hash key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 09 Dec 2014 16:17:55 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	_govind@....com
Cc:	netdev@...r.kernel.org, ssujith@...co.com, benve@...co.com
Subject: Re: [PATCH net-next] enic: add support for set/get rss hash key

From: David Miller <davem@...emloft.net>
Date: Tue, 09 Dec 2014 16:12:18 -0500 (EST)

> From: Govindarajulu Varadarajan <_govind@....com>
> Date: Sun,  7 Dec 2014 22:41:13 +0530
> 
>> This patch adds support for setting/getting rss hash key using ethtool.
>> 
>> Signed-off-by: Govindarajulu Varadarajan <_govind@....com>
> 
> Applied, thanks.

Hmmm...

drivers/net/ethernet/cisco/enic/enic_ethtool.c:461:2: warning: initialization from incompatible pointer type [enabled by default]
drivers/net/ethernet/cisco/enic/enic_ethtool.c:461:2: warning: (near initialization for ‘enic_ethtool_ops.get_rxfh’) [enabled by default]
drivers/net/ethernet/cisco/enic/enic_ethtool.c:462:2: warning: initialization from incompatible pointer type [enabled by default]
drivers/net/ethernet/cisco/enic/enic_ethtool.c:462:2: warning: (near initialization for ‘enic_ethtool_ops.set_rxfh’) [enabled by default]

The function signature has changed for this method, you need to update this
patch and resubmit.

I've reverted it for now.