netdev - Re: [PATCH v2] if_bridge: fix conflict with glibc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141210155745.3d375230@urahara>
Date:	Wed, 10 Dec 2014 15:57:45 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	David Miller <davem@...emloft.net>
Cc:	gregory.0xf0@...il.com, f.fainelli@...il.com,
	xiyou.wangcong@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2] if_bridge: fix conflict with glibc

On Wed, 10 Dec 2014 13:34:17 -0500 (EST)
David Miller <davem@...emloft.net> wrote:

> From: Stephen Hemminger <stephen@...workplumber.org>
> Date: Tue, 9 Dec 2014 21:41:22 -0800
> 
> > Even though kernel and glibc headers have same effective values
> > Gcc complains about redefinitions. Since this is a header expected
> > to be used by userspace, use glibc header.
> > 
> > This supersedes change in commit 66f1c44887ba4f47d617f8ae21cf8e04e1892bd7
> > and fixes build of iproute2 with Glibc-2.19. This follows similar usage
> > in include/uapi/linux for l2tp.h
> > 
> > Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
> > 
> > --- a/include/uapi/linux/if_bridge.h	2014-12-09 20:25:21.656016605 -0800
> > +++ b/include/uapi/linux/if_bridge.h	2014-12-09 21:32:01.391034756 -0800
> > @@ -15,7 +15,9 @@
> >  
> >  #include <linux/types.h>
> >  #include <linux/if_ether.h>
> > -#include <linux/in6.h>
> > +#ifndef __KERNEL__
> > +#include <netinet/in.h>
> > +#endif
> 
> No, we really want to incluse the linux/in6.h header, as that's where all
> the special GLIBC CPP checks are, such as:
> 
> #if __UAPI_DEF_IN6_ADDR_ALT
> 
> Please research how we have resolved the conflict between GLIBC and the
> kernel's exported headers.  We really need to use linux/in6.h for all of
> this to work.
> 
> I understand that it is upsetting that iproute2 stopped building for you,
> but I'd like to kindly ask that you look more deeply into this and think
> more longer term, rather than having a knee jerk reaction and looking for
> quick fixes.

I don't have the time to understand the intricacies of glibc headers.
The problem is that Gcc warns about duplicate definitions in headers;
this is a useful warning and not something that I want to disable.
Hacks with #undef seem to be heading the wrong way.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html