netdev - Re: [PATCHv1 net] xen-netfront: use correct linear area after linearizing an skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141209.214159.1151143350544712995.davem@davemloft.net>
Date:	Tue, 09 Dec 2014 21:41:59 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	david.vrabel@...rix.com
Cc:	netdev@...r.kernel.org, xen-devel@...ts.xenproject.org,
	konrad.wilk@...cle.com, boris.ostrovsky@...cle.com
Subject: Re: [PATCHv1 net] xen-netfront: use correct linear area after
 linearizing an skb

From: David Vrabel <david.vrabel@...rix.com>
Date: Tue, 9 Dec 2014 18:43:28 +0000

> Commit 97a6d1bb2b658ac85ed88205ccd1ab809899884d (xen-netfront: Fix
> handling packets on compound pages with skb_linearize) attempted to
> fix a problem where an skb that would have required too many slots
> would be dropped causing TCP connections to stall.
> 
> However, it filled in the first slot using the original buffer and not
> the new one and would use the wrong offset and grant access to the
> wrong page.
> 
> Netback would notice the malformed request and stop all traffic on the
> VIF, reporting:
> 
>     vif vif-3-0 vif3.0: txreq.offset: 85e, size: 4002, end: 6144
>     vif vif-3-0 vif3.0: fatal error; disabling device
> 
> Reported-by: Anthony Wright <anthony@...rnetdata.com>
> Tested-by: Anthony Wright <anthony@...rnetdata.com>
> Signed-off-by: David Vrabel <david.vrabel@...rix.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html