netdev - RE: [net-next PATCH 6/6] ethernet/broadcom: Use napi_alloc_skb instead of netdev_alloc_skb_ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CA09DA9@AcuExch.aculab.com>
Date:	Wed, 10 Dec 2014 09:52:12 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	David Laight <David.Laight@...LAB.COM>,
	'Alexander Duyck' <alexander.h.duyck@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	Florian Fainelli <f.fainelli@...il.com>,
	"eric.dumazet@...il.com" <eric.dumazet@...il.com>,
	Ariel Elior <ariel.elior@...gic.com>,
	"brouer@...hat.com" <brouer@...hat.com>,
	Gary Zambrano <zambrano@...adcom.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"ast@...mgrid.com" <ast@...mgrid.com>
Subject: RE: [net-next PATCH 6/6] ethernet/broadcom: Use napi_alloc_skb
 instead of netdev_alloc_skb_ip_align

From: David Laight
> From: Alexander Duyck
> > This patch replaces the calls to netdev_alloc_skb_ip_align in the
> > copybreak paths.
> 
> Why?
> 
> You still want the IP header to be aligned and you also want the
> memcpy() to be copying aligned data.
> 
> I suspect this fails on both counts?

Or am I confused by the naming?

	David

> 	David
> 
> > Cc: Gary Zambrano <zambrano@...adcom.com>
> > Cc: Florian Fainelli <f.fainelli@...il.com>
> > Cc: Ariel Elior <ariel.elior@...gic.com>
> > Signed-off-by: Alexander Duyck <alexander.h.duyck@...hat.com>
> > ---
> >  drivers/net/ethernet/broadcom/b44.c             |    2 +-
> >  drivers/net/ethernet/broadcom/bcm63xx_enet.c    |    2 +-
> >  drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c |    2 +-
> >  3 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/broadcom/b44.c
> > index ffeaf47..d86d6ba 100644
> > --- a/drivers/net/ethernet/broadcom/b44.c
> > +++ b/drivers/net/ethernet/broadcom/b44.c
> > @@ -836,7 +836,7 @@ static int b44_rx(struct b44 *bp, int budget)
> >  			struct sk_buff *copy_skb;
> >
> >  			b44_recycle_rx(bp, cons, bp->rx_prod);
> > -			copy_skb = netdev_alloc_skb_ip_align(bp->dev, len);
> > +			copy_skb = napi_alloc_skb(&bp->napi, len);
> >  			if (copy_skb == NULL)
> >  				goto drop_it_no_recycle;
...