netdev - Re: [PATCH net v2] gianfar: Fix dma check map error when DMA_API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141211.142751.14939995747583356.davem@davemloft.net>
Date:	Thu, 11 Dec 2014 14:27:51 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	haokexin@...il.com
Cc:	netdev@...r.kernel.org, claudiu.manoil@...escale.com
Subject: Re: [PATCH net v2] gianfar: Fix dma check map error when
 DMA_API_DEBUG is enabled

From: Kevin Hao <haokexin@...il.com>
Date: Thu, 11 Dec 2014 14:08:41 +0800

> We need to use dma_mapping_error() to check the dma address returned
> by dma_map_single/page(). Otherwise we would get warning like this:
 ...
> For TX, we need to unmap the pages which has already been mapped and
> free the skb before return.
> 
> For RX, move the dma mapping and error check to gfar_new_skb(). We
> would reuse the original skb in the rx ring when either allocating
> skb failure or dma mapping error.
> 
> Signed-off-by: Kevin Hao <haokexin@...il.com>
> Signed-off-by: Claudiu Manoil <claudiu.manoil@...escale.com>
> ---
> v2: Just update the RX path to reuse the original skb when dma mapping error
>     occurs as suggested by David.

Looks good, applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html