netdev - Re: [ovs-dev] [PATCH] net: openvswitch: Support masked set actions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEP_g=8vm3+028GVdh-4DidOzpgfNiNQB7T1OqJ-_jOdPNU5Dw@mail.gmail.com>
Date:	Wed, 10 Dec 2014 18:03:47 -0800
From:	Jesse Gross <jesse@...ira.com>
To:	Jarno Rajahalme <jrajahalme@...ira.com>
Cc:	netdev <netdev@...r.kernel.org>,
	"dev@...nvswitch.org" <dev@...nvswitch.org>
Subject: Re: [ovs-dev] [PATCH] net: openvswitch: Support masked set actions.

On Tue, Dec 9, 2014 at 4:10 PM, Jarno Rajahalme <jrajahalme@...ira.com> wrote:
> diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c
> index df3c7f2..276bb60 100644
> --- a/net/openvswitch/flow_netlink.c
> +++ b/net/openvswitch/flow_netlink.c
> @@ -2007,6 +2117,18 @@ int ovs_nla_put_actions(const struct nlattr *attr, int len, struct sk_buff *skb)
>                                 return err;
>                         break;
>
> +               case OVS_ACTION_ATTR_SET_MASKED:
> +                       err = masked_set_action_to_attr(a, skb);
> +                       if (err)
> +                               return err;
> +                       break;

I don't think this is necessary - the default case will handle things
that don't need any special processing.

I think you can also remove the port checks in validate_tp_port()
since the reasoning behind them is the same as the IP proto check.

Otherwise, I'm generally happy with this though.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html