netdev - Re: [PATCH net-next] bridge: Add ability to always enable TSO/UFO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5488FF63.8020609@lab.ntt.co.jp>
Date:	Thu, 11 Dec 2014 11:20:19 +0900
From:	Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
To:	David Miller <davem@...emloft.net>
CC:	stephen@...workplumber.org, netdev@...r.kernel.org,
	bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net-next] bridge: Add ability to always enable TSO/UFO

On 2014/12/11 11:13, David Miller wrote:
> From: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
> Date: Thu, 11 Dec 2014 11:04:44 +0900
> 
>> On 2014/12/11 4:50, David Miller wrote:
>>> From: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
>>> Date: Wed, 10 Dec 2014 11:43:14 +0900
>>>
>>>> -	features &= ~NETIF_F_ONE_FOR_ALL;
>>>> +	features &= ~NETIF_F_ONE_FOR_ALL | NETIF_F_GSO_SOFTWARE;
>>>
>>> I don't think this is the expression you intend to use.
>>
>> Thank you, but this is really my intended expression.
>>
>> "features &= ~NETIF_F_ONE_FOR_ALL" drops all of ONE_FOR_ALL bits
>> including GSO_SOFTWARE.
>> But I want to leave GSO_SOFTWARE bits here.
> 
> It is clearer to say this as:
> 
> 	~(NETIF_F_ONE_FOR_ALL & ~NETIF_F_GSO_SOFTWARE)
> 
> Or create a new NETIF_F_* macro to express this idea succinctly.

OK, I will. (once net-next is reopened)

Thanks,
Toshiaki Makita

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html