netdev - Re: randconfig build error with next-20141210, in drivers/net/ethernet/broadcom/genet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141212.110223.1096319955510441330.davem@davemloft.net>
Date:	Fri, 12 Dec 2014 11:02:23 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
Cc:	jim.epost@...il.com, sfr@...b.auug.org.au,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: randconfig build error with next-20141210, in
 drivers/net/ethernet/broadcom/genet

From: Florian Fainelli <f.fainelli@...il.com>
Date: Thu, 11 Dec 2014 21:09:01 -0800

> Le 11/12/2014 11:22, David Miller a écrit :
>> From: Jim Davis <jim.epost@...il.com> Date: Wed, 10 Dec 2014
>> 09:10:45 -0700
>> 
>>> Building with the attached random configuration file,
>>> 
>>> ERROR: "fixed_phy_register" 
>>> [drivers/net/ethernet/broadcom/genet/genet.ko] undefined!
>> 
>> Florian, I don't understand why FIXED_PHY is only selected in
>> Kconfig if the driver is statically built into the kernel.
>> 
>> That makes no sense at all, you should need that module regardless
>> of how the driver itself is enabled.
> 
> AFAIR this was introduced to silence a warning you reported:
> 
> "I think you need to work on the Kconfig dependencies a little bit more.
> I have BCMGENET specified as modular, which absolutely should work.  Yet
> Kconfig complains.
> 
> warning: (BCMGENET) selects FIXED_PHY which has unmet direct
> dependencies (NETDEVICES && PHYLIB=y)"
> 
> but I agree, this makes no sense, we should select FIXED_PHY
> unconditionnally, will send you patches tomorrow to fix that.

What's really perplexing is that FIXED_PHY is only enable'able
when PHYLIB=y.  I think that's the core of the problems here.

All of these drivers shouldn't lose fixed phy support simply
because they, or PHYLIB itself, is built modular.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html