lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 14 Dec 2014 23:33:54 +0100 From: Jiri Pirko <jiri@...nulli.us> To: Or Gerlitz <gerlitz.or@...il.com> Cc: Or Gerlitz <ogerlitz@...lanox.com>, "David S. Miller" <davem@...emloft.net>, Linux Netdev List <netdev@...r.kernel.org>, Andy Gospodarek <gospo@...ulusnetworks.com>, Jamal Hadi Salim <jhs@...atatu.com>, John Fastabend <john.r.fastabend@...el.com> Subject: Re: [PATCH net] net: Disallow providing non zero VLAN ID for NIC drivers FDB add flow Sun, Dec 14, 2014 at 09:14:27PM CET, gerlitz.or@...il.com wrote: >On Sun, Dec 14, 2014 at 9:23 PM, Jiri Pirko <jiri@...nulli.us> wrote: >> Sun, Dec 14, 2014 at 05:19:05PM CET, ogerlitz@...lanox.com wrote: >>>The current implementations all use dev_uc_add_excl() and such whose API >>>doesn't support vlans, so we can't make it with NICs HW for now. >>> >>>Fixes: f6f6424ba773 ('net: make vid as a parameter for ndo_fdb_add/ndo_fdb_del') >> >> Maybe I'm missing something, but this commit did not introduce the >> problem. > >This commit introduced the vid param to ndo_fdb_add and ndo_dflt_fdb_add >which further call the dev_uc_add APIs... so it did introduced the >ability to provide VID into these APIs, right? and we want to protect >against anyone using this ability @ this point. That is in-kernel change. Vs. usespace the patch is a no-op. If userspace fills up NDA_VLAN, it is ignored before the patch as well as after. No behaviour change, just +- cosmetics. > >> If was there already before when NDA_VLAN was set and ignored. >> But other than this. I like the patch >> >> Reviewed-by: Jiri Pirko <jiri@...nulli.us> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists