| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20141215085637.GL16916@distanz.ch> Date: Mon, 15 Dec 2014 09:56:38 +0100 From: Tobias Klauser <tklauser@...tanz.ch> To: David Miller <davem@...emloft.net> Cc: tony@...mide.com, nico@...xnic.net, netdev@...r.kernel.org Subject: Re: [PATCH net v2] net: smc91x: Fix build without gpiolib On 2014-12-12 at 17:58:38 +0100, David Miller <davem@...emloft.net> wrote: > From: Tobias Klauser <tklauser@...tanz.ch> > Date: Fri, 12 Dec 2014 17:45:29 +0100 > > > On 2014-12-12 at 17:30:20 +0100, David Miller <davem@...emloft.net> wrote: > >> In my opinion, if the code blocks enabling the configurations that > >> need this are enabled, so should GPIO be depended upon. > >> > >> I think, at a minimum, when CONFIG_OF is enabled smsc91x should > >> require GPIO. > > > > Agreed. This is the better solution, causing less surprises for the > > user. Should this be a "select GPIOLIB if OF" then? > > If GPIO is a child node in the Kconfig hierarchy (ie. has no > dependencies of it's own), then yes. Otherwise, a depends > will need to be used, because select does not recursively > trigger a select'd nodes dependencies. Thank you for the explanation. Since GPIOLIB depends on ARCH_WANT_OPTIONAL_GPIOLIB || ARCH_REQUIRE_GPIOLIB, I think it's appropriate to let SMC91X depend on (!OF || GPIOLIB). I'll send an updated patch. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists