netdev - Re: [PATCH 3/5] e1000e: do not toggle LANPHYPC value bit when PHY reset is blocked

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <548ECDAC.90207@cogentembedded.com>
Date:	Mon, 15 Dec 2014 15:01:48 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Zhu Yanjun <zyjzyj2000@...il.com>, netdev@...r.kernel.org, w@....eu
CC:	Zhu Yanjun <Yanjun.Zhu@...driver.com>,
	Bruce Allan <bruce.w.allan@...el.com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Subject: Re: [PATCH 3/5] e1000e: do not toggle LANPHYPC value bit when PHY
 reset is blocked

Hello.

On 12/15/2014 11:39 AM, Zhu Yanjun wrote:

> 2.6.x kernels require a similar logic change as commit b7d6e335
> [e1000e: do not toggle LANPHYPC value bit when PHY reset is blocked]
> introduces for newer kernels.

    Hm, so is this patch to 2.6.x-stable kernels or a recent kernel?
If the former, you should follow the rules in 
Documentation/stable_kernel_rules.txt.

> When PHY reset is intentionally blocked on 82577/8/9, do not toggle the
> LANPHYPC value bit (essentially performing a hard power reset of the
> device) otherwise the PHY can be put into an unknown state.

> Cleanup whitespace in the same function.

> [yanjun.zhu: whitespace remains unchanged]

> Signed-off-by: Bruce Allan <bruce.w.allan@...el.com>

    So, is this your patch, or Bruce's? If the latter, you should add:

From: Bruce Allan <bruce.w.allan@...el.com>

at the start of the change log.

> Tested-by: Jeff Pieper <jeffrey.e.pieper@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Signed-off-by: Zhu Yanjun <Yanjun.Zhu@...driver.com>

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html