[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <54909DD5.5070202@psc.edu>
Date: Tue, 16 Dec 2014 16:02:13 -0500
From: rapier <rapier@....edu>
To: David Miller <davem@...emloft.net>
CC: alexei.starovoitov@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/3] Implementation of RFC 4898 Extended TCP
Statistics (Web10G)
On 12/16/14 3:18 PM, David Miller wrote:
> From: rapier <rapier@....edu>
> Date: Tue, 16 Dec 2014 15:13:44 -0500
>
>> On 12/16/14, 3:03 PM, David Miller wrote:
>>
>>> You shouldn't need to export any symbols.
>>
>> As a point of clarification - is it acceptable to export symbols for
>> use with in tree modules such as tcp_htcp? We are more than willing to
>> do the work required to bring this in line with best practices.
>
> I'm saying for data and TCP statistics collection, you shouldn't need
> to add any new symbol exports.
We've been able to identify that as the code stands we only need one
export for the KIS. That being said, I understand if that's one too
many. The DLKM (which hasn't been submitted) does require two additional
symbols and that's an oversight on our part. We'll work to eliminate
those as well.
> Keep this in the main kernel, nothing external should be needed.
>
> Extending tcp_info or similar is the only reasonable way to implement
> this stuff.
I understand where you are coming from. I do believe that our
methodology provides some advantages over a tcp_info solution. I'll
provide some information on that tomorrow after I've had a chance to
talk about this in more depth with our dev team. That being said, we
only really care about the instrument set being incorporated as such we
will take a closer look tcp_info shortly.
Chris
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists