[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAAedzxqGhOFJC3DgzgHukr4xOy4YDC_ckoGq9hcLCsSxx2947A@mail.gmail.com>
Date: Tue, 16 Dec 2014 19:38:17 +0900
From: Erik Kline <ek@...gle.com>
To: Lorenzo Colitti <lorenzo@...gle.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>,
Hannes Frederic Sowa <hannes@...essinduktion.org>
Subject: Re: [PATCH net] net: ipv6: allow explicitly choosing optimistic addresses
On Fri, Dec 12, 2014 at 4:37 PM, Lorenzo Colitti <lorenzo@...gle.com> wrote:
> On Fri, Dec 12, 2014 at 12:50 PM, Erik Kline <ek@...gle.com> wrote:
>>
>> @@ -1527,7 +1527,8 @@ int ipv6_chk_addr(struct net *net, const struct in6_addr *addr,
>> if (!net_eq(dev_net(ifp->idev->dev), net))
>> continue;
>> if (ipv6_addr_equal(&ifp->addr, addr) &&
>> - !(ifp->flags&IFA_F_TENTATIVE) &&
>> + (!(ifp->flags&IFA_F_TENTATIVE) ||
>> + ifp->flags&IFA_F_OPTIMISTIC) &&
>> (dev == NULL || ifp->idev->dev == dev ||
>> !(ifp->scope&(IFA_LINK|IFA_HOST) || strict))) {
>> rcu_read_unlock_bh();
>
> I looked at the callers of ipv6_chk_addr (lxr finds 19 files); from
> what I saw, this change will make all of them more correct except for
> ndisc_solicit. With this change, ndisc_solicit could now send
> neighbour solicitations from optimistic addresses, which is not
> allowed by the RFC.
True. I have a version that fixes this, but ended up splitting
ipv6_chk_addr into two:
- ipv6_chk_addr (same as today), and
- ipv6_chk_addr_and_flags (which takes a "u32 banned_flags" argument)
The ugliness of this naming is not lost on me. I briefly tried a
version that reuses the "strict" argument to achieve the same thing,
but that doesn't seem to be quite correct in all cases either.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists