[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <548F940A.4050409@windriver.com>
Date: Tue, 16 Dec 2014 10:08:10 +0800
From: yzhu1 <Yanjun.Zhu@...driver.com>
To: Willy Tarreau <w@....eu>
CC: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
Zhu Yanjun <zyjzyj2000@...il.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"ALLAN, BRUCE" <bruce.w.allan@...el.com>,
"KIRSHER, JEFFREY" <jeffrey.t.kirsher@...el.com>
Subject: Re: [PATCH 3/5] e1000e: do not toggle LANPHYPC value bit when PHY
reset is blocked
Hi, Willy
Thanks for your reply.
I will fix it and send V2.
Best Regards!
Zhu Yanjun
On 12/15/2014 09:33 PM, Willy Tarreau wrote:
> On Mon, Dec 15, 2014 at 01:21:43PM +0000, Zhu, Yanjun wrote:
>> Hi, Willy
>>
>> Thanks for your reply.
>>
>> This patch "[PATCH 3/5] e1000e: do not toggle LANPHYPC value bit when PHY reset is blocked" exists in tag v3.1.
>>
>> Please follow these steps, this patch can be found:
>>
>> 1. git checkout -f v3.1
>>
>> 2. git log -p drivers/net/e1000e/ich8lan.c
>>
>> 3. search "b7d6e335"
>>
>> Then we will find this patch.
> Ah it's because you truncated the commit ID from the right instead of from
> the left. Truncated commit IDs are valid from the left, not from the right.
> In your case, the commit is 6cc7aaed70c96c3933fbacbad582fc79b7d6e335
> ("e1000e: do not toggle LANPHYPC value bit when PHY reset is blocked"), so
> the truncated ID is 6cc7aae, not b7d6e335. It's important to fix that in
> your commit messages so that a "git show" works correctly (it failed for me
> for this precise reason).
>
> Thanks,
> Willy
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists