lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 16 Dec 2014 14:33:32 +0900 From: Simon Horman <horms@...ge.net.au> To: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> Cc: David Miller <davem@...emloft.net>, mitsuhiro.kimura.kc@...esas.com, netdev@...r.kernel.org Subject: Re: errors in alignment changes.. On Fri, Dec 12, 2014 at 03:00:16PM +0300, Sergei Shtylyov wrote: > Hello. > > On 12/12/2014 7:30 AM, Simon Horman wrote: > > >>From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> > >>Date: Thu, 11 Dec 2014 01:08:07 +0300 > > >>> I guess we can just do: > > >>> rxdesc->addr = dma_map_single(...); > > >>Best not to leave a potentially invalid DMA address in a > >>receive descriptor the chip can potentially fetch and > >>look at. > > >>That's why I said to put it into a local variable and > >>check for errors first. > > >Hi Dave, > > >this patch ending up in net is partially my fault. > > >Sergei, do you have time to address David's concerns in relation to this > >patch? > > No, I probably don't. > > >If not I would like to suggest reverting it for now. > > Why? The patch does what it was intended for. Getting rid of > virt_to_phys() calls is a separate issue, IMO. Thanks, that is fine by me. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists