netdev - Re: [PATCH] Documentation: clarify phys_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1418916926.2086.6.camel@dcbw.local>
Date:	Thu, 18 Dec 2014 09:35:26 -0600
From:	Dan Williams <dcbw@...hat.com>
To:	Sathya Perla <Sathya.Perla@...lex.Com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Joshua Watt <jpewdev@...il.com>,
	"jpirko@...hat.com" <jpirko@...hat.com>,
	Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH] Documentation: clarify phys_port_id

On Thu, 2014-12-18 at 05:57 +0000, Sathya Perla wrote:
> > -----Original Message-----
> > From: netdev-owner@...r.kernel.org [mailto:netdev-
> > 
> > Signed-off-by: Dan Williams <dcbw@...hat.com>
> > ---
> >  Documentation/ABI/testing/sysfs-class-net | 7 ++++++-
> >  1 file changed, 6 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/ABI/testing/sysfs-class-net
> > b/Documentation/ABI/testing/sysfs-class-net
> > index e1b2e78..7fe823a 100644
> > --- a/Documentation/ABI/testing/sysfs-class-net
> > +++ b/Documentation/ABI/testing/sysfs-class-net
> > @@ -186,7 +186,12 @@ KernelVersion:	3.12
> >  Contact:	netdev@...r.kernel.org
> >  Description:
> >  		Indicates the interface unique physical port identifier within
> > -		the NIC, as a string.
> > +		the NIC, as a string.  If two net_device objects share physical
> > +		hardware or other resources, and/or do not operate
> > independently
> > +		both net_device objects should be assigned the
> > +		same phys_port_id.  phys_port_id should be as globally
> > unique
> > +		as possible to prevent conflicts between different drivers
> > and
> > +		vendors, eg with MAC addresses or hardware GUIDs.
> 
> Dan, two interfaces -- on the same card/chip -- may share some chip resources,
> but as long as they use *separate* physical ports, it would be OK to bond them.
> So, in this case, it would be valid to report a different phys_port_id for these netdevs.
> 
> The text -- "share physical hardware or other resources" becomes too restrictive
>                                                                           ^^^^^^^^^^^^^^^
> and will not even allow bonding of two physical ports on a NIC card.

Fair enough, I will reword and resubmit.

Dan

> thks,
> -Sathya
> > 
> >  What:		/sys/class/net/<iface>/speed
> >  Date:		October 2009
> > --
> > 1.9.3
> > 
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe netdev" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html