netdev - Re: [PATCH net] enic: fix rx skb checksum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141219.154559.134422023419840492.davem@davemloft.net>
Date:	Fri, 19 Dec 2014 15:45:59 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jbenc@...hat.com
Cc:	_govind@....com, netdev@...r.kernel.org, ssujith@...co.com,
	benve@...co.com, sassmann@...hat.com
Subject: Re: [PATCH net] enic: fix rx skb checksum

From: Jiri Benc <jbenc@...hat.com>
Date: Fri, 19 Dec 2014 12:11:44 +0100

> On Thu, 18 Dec 2014 15:58:42 +0530, Govindarajulu Varadarajan wrote:
>> Hardware always provides compliment of IP pseudo checksum. Stack expects
>> whole packet checksum without pseudo checksum if CHECKSUM_COMPLETE is set.
>> 
>> This causes checksum error in nf & ovs.
>> 
>> [...]
>> 
>> Hardware verifies IP & tcp/udp header checksum but does not provide payload
>> checksum, use CHECKSUM_UNNECESSARY. Set it only if its valid IP tcp/udp packet.
>> 
>> Cc: Jiri Benc <jbenc@...hat.com>
>> Cc: Stefan Assmann <sassmann@...hat.com>
>> Reported-by: Sunil Choudhary <schoudha@...hat.com>
>> Signed-off-by: Govindarajulu Varadarajan <_govind@....com>
> 
> Reviewed-by: Jiri Benc <jbenc@...hat.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html