netdev - RE: [PATCH net-next v3] Add support of Cavium Liquidio ethernet adapters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY2PR07MB486A98FB6C4520C7DEDA564FE6B0@BY2PR07MB486.namprd07.prod.outlook.com>
Date:	Fri, 19 Dec 2014 22:20:34 +0000
From:	"Chickles, Derek" <Derek.Chickles@...iumnetworks.com>
To:	Lino Sanfilippo <LinoSanfilippo@....de>,
	"Vatsavayi, Raghu" <Raghu.Vatsavayi@...iumnetworks.com>,
	"davem@...emloft.net" <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Burla, Satananda" <Satananda.Burla@...iumnetworks.com>,
	"Manlunas, Felix" <Felix.Manlunas@...iumnetworks.com>,
	"Vatsavayi, Raghu" <Raghu.Vatsavayi@...iumnetworks.com>,
	Stephen Hemminger <stephen@...workplumber.org>
Subject: RE: [PATCH net-next v3] Add support of Cavium Liquidio ethernet
 adapters

> On 19.12.2014 04:25, Raghu Vatsavayi wrote:
> > +static void cn6xxx_disable_interrupt(void *chip)
> > +{
> > +	struct octeon_cn6xxx *cn6xxx = (struct octeon_cn6xxx *)chip;
> > +
> > +	/* Disable Interrupts */
> > +	writeq(0, cn6xxx->intr_enb_reg64);
> > +}
> > +
> 
> This could also be a good candidate for forced write posting. The code
> assumes that interrupts are actually deactivated after that.
> 
> Regards,
> Lino
> 
> 
Good catch. We'll examine all the writeq and OCTEON_PCI_WIN_WRITE
calls to make sure there aren't any other critical posted write scenarios that
we've missed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html