netdev - [PATCH Iproute2 next] ip netns: 'ip netns id' cmd without argument should not give error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1418969138-26199-1-git-send-email-maheshb@google.com>
Date:	Thu, 18 Dec 2014 22:05:38 -0800
From:	Mahesh Bandewar <maheshb@...gle.com>
To:	netdev <netdev@...r.kernel.org>,
	Stephen Hemminger <stephen@...workplumber.org>
Cc:	Vadim Kochan <vadim4j@...il.com>, Saied Kazemi <saied@...gle.com>,
	Mahesh Bandewar <maheshb@...gle.com>
Subject: [PATCH Iproute2 next] ip netns: 'ip netns id' cmd without argument should not give error

The command 'ip netns identify' without PID parameter is supposed to
use the self PID to identify its ns but a trivial error prevented it
from doing so. This patch fixes that error.

So before the patch -
	# ip netns id
	No pid specified
	# echo $?
	1
	#

After the patch -
	# ip netns id
	test-ns
	# echo $?
	0
	#

Signed-off-by: Mahesh Bandewar <maheshb@...gle.com>
Cc: Stephen Hemminger <stephen@...workplumber.org>
Cc: Vadim Kochan <vadim4j@...il.com> 
Cc: Saied Kazemi <saied@...gle.com>
---
 ip/ipnetns.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ip/ipnetns.c b/ip/ipnetns.c
index 1c8aa029073e..ec9afa2177a5 100644
--- a/ip/ipnetns.c
+++ b/ip/ipnetns.c
@@ -298,7 +298,7 @@ static int netns_identify(int argc, char **argv)
 	DIR *dir;
 	struct dirent *entry;
 
-	if (argc < 1) {
+	if (!argc) {
 		pidstr = "self";
 	} else if (argc > 1) {
 		fprintf(stderr, "extra arguments specified\n");
-- 
2.2.0.rc0.207.ga3a616c

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html