netdev - Re: [PATCH] sunvnet: fix a memory leak in vnet_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <549462DF.7050709@oracle.com>
Date:	Fri, 19 Dec 2014 12:39:43 -0500
From:	David L Stevens <david.stevens@...cle.com>
To:	roy.qing.li@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] sunvnet: fix a memory leak in vnet_handle_offloads


Acked-by: David L Stevens <david.stevens@...cle.com>

On 12/19/2014 12:19 AM, roy.qing.li@...il.com wrote:
> From: Li RongQing <roy.qing.li@...il.com>
> 
> when skb_gso_segment returns error, the original skb should be freed
> 
> Signed-off-by: Li RongQing <roy.qing.li@...il.com>
> ---
>  drivers/net/ethernet/sun/sunvnet.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/sun/sunvnet.c b/drivers/net/ethernet/sun/sunvnet.c
> index 45c408e..d2835bf 100644
> --- a/drivers/net/ethernet/sun/sunvnet.c
> +++ b/drivers/net/ethernet/sun/sunvnet.c
> @@ -1201,6 +1201,7 @@ static int vnet_handle_offloads(struct vnet_port *port, struct sk_buff *skb)
>  		segs = skb_gso_segment(skb, dev->features & ~NETIF_F_TSO);
>  	if (IS_ERR(segs)) {
>  		dev->stats.tx_dropped++;
> +		dev_kfree_skb_any(skb);
>  		return NETDEV_TX_OK;
>  	}
>  
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html