netdev - RE: [PATCH net-next v3] Add support of Cavium Liquidio ethernet adapters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO2PR07MB4901478A88B982967DBACA0FE6B0@CO2PR07MB490.namprd07.prod.outlook.com>
Date:	Fri, 19 Dec 2014 17:54:58 +0000
From:	"Chickles, Derek" <Derek.Chickles@...iumnetworks.com>
To:	Stephen Hemminger <stephen@...workplumber.org>,
	"Vatsavayi, Raghu" <Raghu.Vatsavayi@...iumnetworks.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Burla, Satananda" <Satananda.Burla@...iumnetworks.com>,
	"Manlunas, Felix" <Felix.Manlunas@...iumnetworks.com>,
	"Vatsavayi, Raghu" <Raghu.Vatsavayi@...iumnetworks.com>
Subject: RE: [PATCH net-next v3] Add support of Cavium Liquidio ethernet
 adapters

> > +static struct {
> > +	const char str[ETH_GSTRING_LEN];
> > +} ethtool_stats_keys[] = {
> > +	{
> > +		"jiffies"
> > +	}, {
> 
> Jiffies does not belong in ethtool stats. Looks like some developer debug
> option.

The intention here was to have a semi-accurate timestamp taken at the time
the statistics were gathered before handing it over to userspace. This is a
generic requirement though, so it probably belongs in ethtool_get_stats().
Otherwise, we can publish some per-second stats if that's preferable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html