netdev - Re: [bisected] tg3 broken in 3.18.0?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAA93t1qsPE=otZNe-Bf5yYiWtB_Zrf4q8zAiFApUNqpm8Gt28A@mail.gmail.com>
Date:	Fri, 19 Dec 2014 11:37:55 -0800
From:	Rajat Jain <rajatxjain@...il.com>
To:	Prashant Sreedharan <prashant@...adcom.com>
Cc:	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Nils Holland <nholland@...ys.org>,
	Michael Chan <mchan@...adcom.com>,
	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	Rafael Wysocki <rjw@...ysocki.net>
Subject: Re: [bisected] tg3 broken in 3.18.0?

On Fri, Dec 19, 2014 at 10:53 AM, Prashant Sreedharan
<prashant@...adcom.com> wrote:
> On Fri, 2014-12-19 at 10:24 -0800, Rajat Jain wrote:
>> One of the reasons to replace the condition (*l == 0xffff0001) with
>> (*l & 0xffff) == 0x0001) was that some devices apparently returned
>> 0001 for device id to indicate CRS, but returned actual vendor id in
>> the vendor ID field (hence the need to ignore vendor field).
>>
>> Are we saying that the tg3 device returns 0x0001 for the device ID and
>> yet expects it to be treated as a good value (not CRS)?
>>
> No it should not be treated as a good value, this commit has
> surfaced/exposed a problem in 5722 chipset which was previously masked.
>

Got it. Thanks.

I assume you mean its a HW issue, and the workaround if required shall
be taken care in tg3 driver.

Thanks,

Rajat

>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html