| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20141220221606.GA2591@teela.fritz.box> Date: Sat, 20 Dec 2014 23:16:07 +0100 From: Nils Holland <nholland@...ys.org> To: Prashant Sreedharan <prashant@...adcom.com> Cc: davem@...emloft.net, netdev@...r.kernel.org, linux-pci@...r.kernel.org, marcelo.leitner@...il.com, bhelgaas@...gle.com, rajatxjain@...il.com, Michael Chan <mchan@...adcom.com> Subject: Re: [PATCH net]tg3: tg3_disable_ints using uninitialized mailbox value to disable interrupts On Sat, Dec 20, 2014 at 12:16:17PM -0800, Prashant Sreedharan wrote: > > This driver bug was exposed because of the commit a7877b17a667 (PCI: Check only > the Vendor ID to identify Configuration Request Retry). Also this issue is only > seen in older generation chipsets like 5722 because config space write to offset > 0 from driver is possible. > > Fixed by initializing the interrupt mailbox registers before calling tg3_halt. > > Please queue for -stable. I gave this patch a try and can confirm what was to be expected: It fixes the issue and the network interface is once again working properly on my system. Thus, I guess the issue is adequately solved. Thanks to everyone involved, especially to Marcelo for additional debugging and the guys at Broadcom for the quick fix! Greetings, Nils -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists