lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 21 Dec 2014 16:57:59 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Jia-Ju Bai <baijiaju1990@....com>, David Miller <davem@...emloft.net>, netdev@...r.kernel.org CC: todd.fujinaka@...el.com, Linux-nics@...tope.jf.intel.com, linux.nics@...el.com, e1000-devel@...ts.sourceforge.net Subject: Re: [PATCH V2] e1000: Add netif_napi_del in the normal path and error path to match netif_napi_add Hello. On 12/21/2014 3:52 AM, Jia-Ju Bai wrote: > Th driver lacks netif_napi_del in the normal path and error path to match the > call of netif_napi_add in e1000_probe. Please wrap your change log lines at 80 columns (or less). > This patch fixes this problem, and it has been tested in runtime. > Signed-off-by: Jia-Ju Bai<baijiaju1990@....com> > --- > drivers/net/ethernet/intel/e1000/e1000_main.c | 6 +- > 1 file changed, 4 insertions(+), 2 deletions(-) > diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c > b/drivers/net/ethernet/intel/e1000/e1000_main.c > > index 24f3986..f6def7b 100644 > > --- a/drivers/net/ethernet/intel/e1000/e1000_main.c > > +++ b/drivers/net/ethernet/intel/e1000/e1000_main.c > > @@ -1004,7 +1004,7 @@ static int e1000_probe(struct pci_dev *pdev, const > struct pci_device_id *ent) > > /* make ready for any if (hw->...) below */ > > err = e1000_init_hw_struct(adapter, hw); > > if (err) > > - goto err_sw_init; > > + goto err_dma; > > /* there is a workaround being applied below that limits > > * 64-bit DMA addresses to 64-bit hardware. There are some Somehow your mailer inserted empty lines after each actual line of the patch. :-( WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists