netdev - Re: [PATCH net] net/core: Handle csum for CHECKSUM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141222.162143.1589102649309575725.davem@davemloft.net>
Date:	Mon, 22 Dec 2014 16:21:43 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jay.vosburgh@...onical.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] net/core: Handle csum for CHECKSUM_COMPLETE VXLAN
 forwarding

From: Jay Vosburgh <jay.vosburgh@...onical.com>
Date: Fri, 19 Dec 2014 15:32:00 -0800

> 	The receive code is careful to update the skb->csum, except in
> __dev_forward_skb, as called by dev_forward_skb.  __dev_forward_skb
> calls eth_type_trans, which in turn calls skb_pull_inline(skb, ETH_HLEN)
> to skip over the Ethernet header, but does not update skb->csum when
> doing so.

Hmmm, wasn't there some discussion about doing the skb_postpull_rcsum()
in eth_type_trans()?

But I guess that won't work for non-encapsulated ethernet cases?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html