netdev - Re: [PATCH 3/3] net: ieee802154: don't use devm_pinctrl_get_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 23 Dec 2014 05:58:29 +0530
From:	Varka Bhadram <varkabhadram@...il.com>
To:	unlisted-recipients:; (no To-header on input)
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	linux-wpan - ML <linux-wpan@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 3/3] net: ieee802154: don't use devm_pinctrl_get_select_default()
 in probe

Thanks for the patch.

Acked-by: Varka Bhadram <varkabhadram@...il.com>

On Tue, Dec 23, 2014 at 5:40 AM, Varka Bhadram <varkabhadram@...il.com> wrote:
>
> Thanks for the patch.
>
> Acked-by: Varka Bhadram <varkabhadram@...il.com>
>
> On Tue, Dec 23, 2014 at 3:46 AM, Wolfram Sang <wsa@...-dreams.de> wrote:
>>
>> Since commit ab78029ecc34 (drivers/pinctrl: grab default handles from device
>> core), we can rely on device core for setting the default pins.
>>
>> Signed-off-by: Wolfram Sang <wsa@...-dreams.de>
>> ---
>>  drivers/net/ieee802154/cc2520.c | 7 -------
>>  1 file changed, 7 deletions(-)
>>
>> diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
>> index c2b7da3da183..033473448d9f 100644
>> --- a/drivers/net/ieee802154/cc2520.c
>> +++ b/drivers/net/ieee802154/cc2520.c
>> @@ -19,7 +19,6 @@
>>  #include <linux/workqueue.h>
>>  #include <linux/interrupt.h>
>>  #include <linux/skbuff.h>
>> -#include <linux/pinctrl/consumer.h>
>>  #include <linux/of_gpio.h>
>>  #include <linux/ieee802154.h>
>>
>> @@ -841,7 +840,6 @@ done:
>>  static int cc2520_probe(struct spi_device *spi)
>>  {
>>         struct cc2520_private *priv;
>> -       struct pinctrl *pinctrl;
>>         struct cc2520_platform_data *pdata;
>>         int ret;
>>
>> @@ -854,11 +852,6 @@ static int cc2520_probe(struct spi_device *spi)
>>
>>         spi_set_drvdata(spi, priv);
>>
>> -       pinctrl = devm_pinctrl_get_select_default(&spi->dev);
>> -       if (IS_ERR(pinctrl))
>> -               dev_warn(&spi->dev,
>> -                        "pinctrl pins are not configured\n");
>> -
>>         pdata = cc2520_get_platform_data(spi);
>>         if (!pdata) {
>>                 dev_err(&spi->dev, "no platform data\n");
>> --
>> 2.1.3
>>
>
>
>
> --
> Thanks and Regards,
> Varka Bhadram.




-- 
Thanks and Regards,
Varka Bhadram.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html