netdev - Re: [PATCH net] net: Fix stacked vlan offload features computation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141224.000917.2245589354389943898.davem@davemloft.net>
Date:	Wed, 24 Dec 2014 00:09:17 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	makita.toshiaki@....ntt.co.jp
Cc:	jesse@...ira.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] net: Fix stacked vlan offload features computation

From: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
Date: Mon, 22 Dec 2014 19:04:14 +0900

> When vlan tags are stacked, it is very likely that the outer tag is stored
> in skb->vlan_tci and skb->protocol shows the inner tag's vlan_proto.
> Currently netif_skb_features() first looks at skb->protocol even if there
> is the outer tag in vlan_tci, thus it incorrectly retrieves the protocol
> encapsulated by the inner vlan instead of the inner vlan protocol.
> This allows GSO packets to be passed to HW and they end up being
> corrupted.
> 
> Fixes: 58e998c6d239 ("offloading: Force software GSO for multiple vlan tags.")
> Signed-off-by: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html