netdev - Re: [PATCH 2/3] net/fsl: remove irq assignment from xgmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <549A9AA1.4020806@cogentembedded.com>
Date:	Wed, 24 Dec 2014 13:51:13 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Shaohui Xie <Shaohui.Xie@...escale.com>
CC:	"shh.xie@...il.com" <shh.xie@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [PATCH 2/3] net/fsl: remove irq assignment from xgmac_mdio

Hello.

On 12/24/2014 5:22 AM, Shaohui Xie wrote:

[...]

>>> From: Shaohui Xie <Shaohui.Xie@...escale.com>

>>> Which is wrong and not used, so no extra space needed by
>>> mdio_alloc_size(), change the parameter accordingly.

>>> Signed-off-by: Shaohui Xie <Shaohui.Xie@...escale.com>
>>> ---
>>>    drivers/net/ethernet/freescale/xgmac_mdio.c | 3 +--
>>>    1 file changed, 1 insertion(+), 2 deletions(-)

>>> diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c
>>> b/drivers/net/ethernet/freescale/xgmac_mdio.c
>>> index 90adba1..72e0b85 100644
>>> --- a/drivers/net/ethernet/freescale/xgmac_mdio.c
>>> +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
>>> @@ -187,14 +187,13 @@ static int xgmac_mdio_probe(struct platform_device *pdev)
>>>    		return ret;
>>>    	}
>>>
>>> -	bus = mdiobus_alloc_size(PHY_MAX_ADDR * sizeof(int));
>>> +	bus = mdiobus_alloc_size(0);

>>      It's now equivalent to a mere mdiobus_alloc().

> [S.H] Yes, mdiobus_alloc() defined as:

> static inline struct mii_bus *mdiobus_alloc(void)
> {
>          return mdiobus_alloc_size(0);
> }

> Should I use mdiobus_alloc() instead?

    Yes, I meant it.

> Thanks!
> Shaohui

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html