lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 24 Dec 2014 18:50:11 -0800 From: Greg KH <gregkh@...uxfoundation.org> To: "Ahmed S. Darwish" <darwish.07@...il.com> Cc: Olivier Sobrie <olivier@...rie.be>, Oliver Hartkopp <socketcan@...tkopp.net>, Wolfgang Grandegger <wg@...ndegger.com>, Marc Kleine-Budde <mkl@...gutronix.de>, "David S. Miller" <davem@...emloft.net>, Paul Gortmaker <paul.gortmaker@...driver.com>, Linux-CAN <linux-can@...r.kernel.org>, netdev <netdev@...r.kernel.org>, Linux-stable <stable@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2 1/4] can: kvaser_usb: Don't free packets when tight on URBs On Thu, Dec 25, 2014 at 01:56:44AM +0200, Ahmed S. Darwish wrote: > From: Ahmed S. Darwish <ahmed.darwish@...eo.com> > > Flooding the Kvaser CAN to USB dongle with multiple reads and > writes in high frequency caused seemingly-random panics in the > kernel. > > On further inspection, it seems the driver erroneously freed the > to-be-transmitted packet upon getting tight on URBs and returning > NETDEV_TX_BUSY, leading to invalid memory writes and double frees > at a later point in time. > > Note: > > Finding no more URBs/transmit-contexts and returning NETDEV_TX_BUSY > is a driver bug in and out of itself: it means that our start/stop > queue flow control is broken. > > This patch only fixes the (buggy) error handling code; the root > cause shall be fixed in a later commit. > > Signed-off-by: Ahmed S. Darwish <ahmed.darwish@...eo.com> > --- > drivers/net/can/usb/kvaser_usb.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > (Marc, Greg, I believe this should also be added to -stable?) <formletter> This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read Documentation/stable_kernel_rules.txt for how to do this properly. </formletter> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists