netdev - RE: [PATCH net v2] net: Generalize ndo_gso_check tondo_features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0835B3720019904CB8F7AA43166CEEB2EDB4FC@RTITMBSV03.realtek.com.tw>
Date:	Thu, 25 Dec 2014 03:29:59 +0000
From:	Hayes Wang <hayeswang@...ltek.com>
To:	Jesse Gross <jesse@...ira.com>, David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Tom Herbert <therbert@...gle.com>,
	Joe Stringer <joestringer@...ira.com>,
	Eric Dumazet <edumazet@...gle.com>
Subject: RE: [PATCH net v2] net: Generalize ndo_gso_check tondo_features_check

 Jesse Gross [mailto:jesse@...ira.com] 
> Sent: Wednesday, December 24, 2014 2:37 PM
[...]
> GSO isn't the only offload feature with restrictions that
> potentially can't be expressed with the current features mechanism.
> Checksum is another although it's a general issue that could in
> theory apply to anything. Even if it may be possible to
> implement these restrictions in other ways, it can result in
> duplicate code or inefficient per-packet behavior.
> 
> This generalizes ndo_gso_check so that drivers can remove any
> features that don't make sense for a given packet, similar to
> netif_skb_features(). It also converts existing driver
> restrictions to the new format, completing the work that was
> done to support tunnel protocols since the issues apply to
> checksums as well.
> 
> By actually removing features from the set that are used to do
> offloading, it solves another problem with the existing
> interface. In these cases, GSO would run with the original set
> of features and not do anything because it appears that
> segmentation is not required.
> 
> CC: Tom Herbert <therbert@...gle.com>
> CC: Joe Stringer <joestringer@...ira.com>
> CC: Eric Dumazet <edumazet@...gle.com>
> CC: Hayes Wang <hayeswang@...ltek.com>
> Signed-off-by: Jesse Gross <jesse@...ira.com>
> Acked-by:  Tom Herbert <therbert@...gle.com>
> Fixes: 04ffcb255f22 ("net: Add ndo_gso_check")
> ---
> v2: Rebase
>     Drop overzealous use of netdev_intersect_features()

Tested-by: Hayes Wang <hayeswang@...ltek.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html