netdev - Re: [PATCH] netlink/genetlink: pass network namespace to bind/unbind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141227.030805.2148263042773135498.davem@davemloft.net>
Date:	Sat, 27 Dec 2014 03:08:05 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	johannes@...solutions.net
Cc:	netdev@...r.kernel.org, johannes.berg@...el.com
Subject: Re: [PATCH] netlink/genetlink: pass network namespace to
 bind/unbind

From: Johannes Berg <johannes@...solutions.net>
Date: Tue, 23 Dec 2014 21:00:06 +0100

> From: Johannes Berg <johannes.berg@...el.com>
> 
> Netlink families can exist in multiple namespaces, and for the most
> part multicast subscriptions are per network namespace. Thus it only
> makes sense to have bind/unbind notifications per network namespace.
> 
> To achieve this, pass the network namespace of a given client socket
> to the bind/unbind functions.
> 
> Also do this in generic netlink, and there also make sure that any
> bind for multicast groups that only exist in init_net is rejected.
> This isn't really a problem if it is accepted since a client in a
> different namespace will never receive any notifications from such
> a group, but it can confuse the family if not rejected (it's also
> possible to silently (without telling the family) accept it, but it
> would also have to be ignored on unbind so families that take any
> kind of action on bind/unbind won't do unnecessary work for invalid
> clients like that.
> 
> Signed-off-by: Johannes Berg <johannes.berg@...el.com>

Applied, thanks Johannes.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html