netdev - Re: [PATCH net] netlink: call cond_resched after broadcasting updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CA+icZUVDCK-kctc6U-S598ZeiJ+bd8PsO1kCaAG3j-_hiOPA=w@mail.gmail.com>
Date:	Sun, 28 Dec 2014 08:28:48 +0100
From:	Sedat Dilek <sedat.dilek@...il.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	David Miller <davem@...emloft.net>,
	Johannes Berg <johannes.berg@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] netlink: call cond_resched after broadcasting updates

Hi,

with your patch on top of upstream.git (Linux-v3.19-rc1-58-g29169f8)
plus net.git#master and some patches from Johannes...

>From my patchset:
...
Johannes Berg (6):
      netlink: rename netlink_unbind() to netlink_undo_bind()
      genetlink: pass only network namespace to genl_has_listeners()
      netlink: update listeners directly when removing socket
      netlink: call unbind when releasing socket
      genetlink: pass multicast bind/unbind to families
      netlink/genetlink: pass network namespace to bind/unbind <---
>From jojojohill!
...
stephen hemminger (2):
      in6: fix conflict with glibc
      netlink: call cond_resched after broadcasting updates <--- Your patch!
...

...I get a call-trace like this...

[   16.378240] BUG: sleeping function called from invalid context at
net/netlink/af_netlink.c:1989
[   16.378312] in_atomic(): 1, irqs_disabled(): 0, pid: 1061, name: ifconfig
[   16.378346] 2 locks held by ifconfig/1061:
[   16.378348]  #0:  (rtnl_mutex){+.+.+.}, at: [<ffffffff81678287>]
rtnl_lock+0x17/0x20
[   16.378358]  #1:  (rcu_read_lock_bh){......}, at:
[<ffffffff817091c5>] ipv6_ifa_notify+0x5/0xa0
[   16.378367] CPU: 2 PID: 1061 Comm: ifconfig Not tainted
3.19.0-rc1-58.2-iniza-small #1
[   16.378369] Hardware name: SAMSUNG ELECTRONICS CO., LTD.
530U3BI/530U4BI/530U4BH/530U3BI/530U4BI/530U4BH, BIOS 13XK 03/28/2013
[   16.378371]  0000000000000008 ffff8800c092fab8 ffffffff8175b5bc
0000000000000005
[   16.378375]  ffff88011a6c6800 ffff8800c092fac8 ffffffff8109c34a
ffff8800c092fb48
[   16.378378]  ffffffff8169500e ffff8800c47cc06c 0000000000000000
00000020cbdcd400
[   16.378381] Call Trace:
[   16.378387]  [<ffffffff8175b5bc>] dump_stack+0x4c/0x65
[   16.378391]  [<ffffffff8109c34a>] ___might_sleep+0xfa/0x130
[   16.378395]  [<ffffffff8169500e>] netlink_broadcast_filtered+0x10e/0x3a0
[   16.378399]  [<ffffffff81696df5>] nlmsg_notify+0xd5/0xf0
[   16.378402]  [<ffffffff816786db>] rtnl_notify+0x3b/0x40
[   16.378404]  [<ffffffff81708fcb>] __ipv6_ifa_notify+0x15b/0x350
[   16.378407]  [<ffffffff81709226>] ipv6_ifa_notify+0x66/0xa0
[   16.378410]  [<ffffffff817091c5>] ? ipv6_ifa_notify+0x5/0xa0
[   16.378414]  [<ffffffff81764949>] ? _raw_spin_unlock_bh+0x39/0x40
[   16.378417]  [<ffffffff8170d072>] addrconf_notify+0x3b2/0x7f0
[   16.378421]  [<ffffffff8109736d>] notifier_call_chain+0x4d/0x80
[   16.378424]  [<ffffffff81097466>] raw_notifier_call_chain+0x16/0x20
[   16.378427]  [<ffffffff81662739>] call_netdevice_notifiers_info+0x39/0x70
[   16.378431]  [<ffffffff8166bbeb>] __dev_notify_flags+0x3b/0xc0
[   16.378434]  [<ffffffff8166c3e3>] dev_change_flags+0x53/0x70
[   16.378437]  [<ffffffff816dc9d9>] devinet_ioctl+0x609/0x6d0
[   16.378441]  [<ffffffff816dd955>] inet_ioctl+0x65/0x90
[   16.378444]  [<ffffffff8164a8c9>] sock_do_ioctl+0x29/0x60
[   16.378447]  [<ffffffff8164ae6b>] sock_ioctl+0x1bb/0x260
[   16.378452]  [<ffffffff8120a668>] do_vfs_ioctl+0x308/0x540
[   16.378456]  [<ffffffff810c2e5d>] ? trace_hardirqs_on_caller+0x15d/0x200
[   16.378459]  [<ffffffff810c2f0d>] ? trace_hardirqs_on+0xd/0x10
[   16.378462]  [<ffffffff8120a921>] SyS_ioctl+0x81/0xa0
[   16.378466]  [<ffffffff817654ad>] system_call_fastpath+0x16/0x1b

I am using here Ubuntu/precise (12.04.5 LTS) with Network-Manager
(0.9.4.0-0ubuntu4.4.2) to setup and configure my network.

Attached are my... kernel-config, dmesg and patchset on top of Linux v3.19-rc1.

If you need additional informations, please contact me.

Regards,
- Sedat -

View attachment "dmesg_3.19.0-rc1-58.2-iniza-small.txt" of type "text/plain" (56675 bytes)

Download attachment "config-3.19.0-rc1-58.2-iniza-small" of type "application/octet-stream" (124049 bytes)

View attachment "3.19.0-rc1-58.2-iniza-small.patch" of type "text/x-diff" (260856 bytes)