lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 29 Dec 2014 21:25:01 -0800 From: Scott Feldman <sfeldma@...il.com> To: roopa <roopa@...ulusnetworks.com> Cc: Netdev <netdev@...r.kernel.org>, shemminger@...tta.com, "vyasevic@...hat.com" <vyasevic@...hat.com>, Wilson Kok <wkok@...ulusnetworks.com> Subject: Re: [PATCH 6/6] bridge: add vlan info to bridge setlink and dellink notification messages On Mon, Dec 29, 2014 at 9:17 PM, roopa <roopa@...ulusnetworks.com> wrote: > On 12/29/14, 3:42 PM, Scott Feldman wrote: >> >> On Mon, Dec 29, 2014 at 1:05 PM, <roopa@...ulusnetworks.com> wrote: >>> >>> From: Roopa Prabhu <roopa@...ulusnetworks.com> >>> >>> vlan add/deletes are not notified to userspace today. This patch fixes >>> it. >>> Notifications will contain vlans compressed into ranges whereever >>> applicable. >> >> Why is this notification needed? On VLAN add/del, the port driver >> will already get called if it implements ndo_vlan_rx_add_vid and >> ndo_vlan_rx_kill_vid. > > This is strictly for userspace. > >> The port driver already gets the notification >> it needs to filter vlans. User space can query for vlan port >> membership if it needs to know. > > > You mean request a dump ?. yes it can if it needs all the configured vlans. > But for notifications, we must at the least notify what changed with respect > to vlans with RTM_SETLINK/DELLINK, no ? You'll get that notification if you implement ndo_vlan_rx_add/kill_vid in your port driver, which is called from RTM_SETLINK/DELLINK. Your port driver can send to user-space, I suppose, if user-space needs notification. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists