lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 29 Dec 2014 23:23:28 -0500 (EST) From: David Miller <davem@...emloft.net> To: wen.gang.wang@...cle.com Cc: netdev@...r.kernel.org, linux-rdma@...r.kernel.org Subject: Re: [PATCH] bonding: move ipoib_header_ops to vmlinux From: Wengang Wang <wen.gang.wang@...cle.com> Date: Tue, 30 Dec 2014 11:04:42 +0800 > When last slave of a bonding master is removed, the bonding then does not work. > At the time if packet_snd is called against with a master net_device, it calls > then header_ops->create which points to slave's header_ops. In case the slave > is ipoib and the module is unloaded, header_ops would point to invalid address. > Accessing it will cause problem. > This patch tries to fix this issue by moving ipoib_header_ops to vmlinux to keep > it valid even when ipoib module is unloaded. > > Signed-off-by: Wengang Wang <wen.gang.wang@...cle.com> Like others, I absolutely do not consider it sustainable to keep moving header_ops implementations into the static kernel image. We're just papering over the real problem, which is making sure all dangling references to something really go away when we release/unload an object. Point it to a dummy set of ops and do a synchronize_net() or similar. I'm not applying this patch, sorry. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists