lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 1 Jan 2015 00:42:17 +1100 From: Herbert Xu <herbert@...dor.apana.org.au> To: Thomas Jarosch <thomas.jarosch@...ra2net.com> Cc: netdev@...r.kernel.org, edumazet@...gle.com, Steffen Klassert <steffen.klassert@...unet.com>, Ben Hutchings <bhutchings@...arflare.com>, "David S. Miller" <davem@...emloft.net> Subject: Re: tcp: Do not apply TSO segment limit to non-TSO packets On Thu, Jan 01, 2015 at 12:39:23AM +1100, Herbert Xu wrote: > > Thomas Jarosch reported IPsec TCP stalls when a PMTU event occurs. > > In fact the problem was completely unrelated to IPsec. The bug is > also reproducible if you just disable TSO/GSO. This raises two interesting questions. Firstly not many people test non-TSO code paths anymore so bugs are likely to persist for a long time there. Perhaps it's time to remove the non-TSO code path altogether? The GSO code path should provide enough speed-up in terms of boosting the effective MTU to offset the cost of copying. Secondly why are we dealing with hardware TSO segment limits by limiting the size of the TSO packet in the TCP stack? Surely in this case GSO is free since there won't be any copying? Cheers, -- Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists