lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 31 Dec 2014 20:36:55 +0200 From: Vlad Zolotarov <vladz@...udius-systems.com> To: Jeff Kirsher <jeffrey.t.kirsher@...el.com>, Alexander Duyck <alexander.duyck@...il.com> CC: netdev@...r.kernel.org, gleb@...udius-systems.com, avi@...udius-systems.com Subject: Re: [PATCH net-next v1 4/5] ixgbevf: Add RSS Key query code On 12/31/14 20:32, Jeff Kirsher wrote: > On Wed, 2014-12-31 at 20:03 +0200, Vlad Zolotarov wrote: >> On 12/31/14 18:28, Jeff Kirsher wrote: >>> On Wed, 2014-12-31 at 11:51 +0200, Vlad Zolotarov wrote: >>>> Signed-off-by: Vlad Zolotarov <vladz@...udius-systems.com> >>>> --- >>>> New in v1 (compared to RFC): >>>> - Use "if-else" statement instead of a "switch-case" for a >> single >>>> option case >>>> (in ixgbevf_get_rss_key()). >>>> >>>> --- >>>> drivers/net/ethernet/intel/ixgbevf/mbx.h | 2 ++ >>>> drivers/net/ethernet/intel/ixgbevf/vf.c | 44 >>>> ++++++++++++++++++++++++++++++++ >>>> drivers/net/ethernet/intel/ixgbevf/vf.h | 1 + >>>> 3 files changed, 47 insertions(+) >>> Just caught this now, sorry but your patch description is sparse >> (i.e. >>> non-existent). I know that the title of the patch pretty much tells >>> what you are doing, but it would be nice to have a bit more detail >> as to >>> why (like your first patch). >> I've sent a v2 where I tried to address your last remarks. Pls., note >> that the whole series "why" motivation is located in the PATCH0 and >> in >> the final PATCH5: adding a new ethtool options for 82599 VF devices. > Thanks v2 appears fine with regards to code/patch format goes. Alex > Duyck appears to have provided feedback on the series, which is a > concern for me. I have dropped v1 (since v2 is out), but I am going to > hold off on pulling in v2 until Alex's concerns have been addressed. Sure. He's caught a few real issues there. The main is that I had only 82599 in mind and there are also x540 and x550 to consider. It may take a day or two... ;) Again, thanks for looking at this guys. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists