lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 30 Dec 2014 23:07:35 -0600 From: Eric Biggers <ebiggers3@...il.com> To: Larry Finger <Larry.Finger@...inger.net> Cc: kvalo@...eaurora.org, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, Stable <stable@...r.kernel.org> Subject: Re: [PATCH V3 for 3.19] rtlwifi: Fix error when accessing unmapped memory in skb On Tue, Dec 30, 2014 at 09:33:07PM -0600, Larry Finger wrote: > v3 - Unmap skb before trying to allocate a new one so as to not leak mapping. Looks good to me, although I'm not sure about the handling of DMA mapping errors (perhaps that's something that drivers typically don't even try to handle?). Anyway, the skb allocation issue appears to be resolved now. I am running your patch with an extra hack to inject some occasional skb allocation failures, and I haven't noticed any problems except dropped packets. Eric -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists