lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 02 Jan 2015 21:35:58 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Larry Finger <Larry.Finger@...inger.net>, kvalo@...eaurora.org
CC:	linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 02/11] rtlwifi: rtl8723be: Improve modinfo output

Hello.

On 1/2/2015 7:58 PM, Larry Finger wrote:

> The description of the power-save variables for this driver is not as
> clear as for the others. The wording is changed to match the others.

> Signed-off-by: Larry Finger <Larry.Finger@...inger.net>
> ---
>   drivers/net/wireless/rtlwifi/rtl8723be/sw.c | 11 ++++++-----
>   1 file changed, 6 insertions(+), 5 deletions(-)

> diff --git a/drivers/net/wireless/rtlwifi/rtl8723be/sw.c b/drivers/net/wireless/rtlwifi/rtl8723be/sw.c
> index 223eb42..52a6d90 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8723be/sw.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8723be/sw.c
> @@ -387,12 +387,13 @@ module_param_named(swlps, rtl8723be_mod_params.swctrl_lps, bool, 0444);
>   module_param_named(fwlps, rtl8723be_mod_params.fwctrl_lps, bool, 0444);
>   module_param_named(disable_watchdog, rtl8723be_mod_params.disable_watchdog,
>   		   bool, 0444);
> -MODULE_PARM_DESC(swenc, "using hardware crypto (default 0 [hardware])\n");
> -MODULE_PARM_DESC(ips, "using no link power save (default 1 is open)\n");
> -MODULE_PARM_DESC(fwlps, "using linked fw control power save (default 1 is open)\n");
> -MODULE_PARM_DESC(msi, "Set to 1 to use MSI interrupts mode (default 0)\n");

    You are completely removing this description. Is it intentional?

> +MODULE_PARM_DESC(swenc, "Set to 1 for software crypto (default 0)\n");
> +MODULE_PARM_DESC(ips, "Set to 0 to not use link power save (default 1)\n");
> +MODULE_PARM_DESC(swlps, "Set to 1 to use SW control power save (default 0)\n");
> +MODULE_PARM_DESC(fwlps, "Set to 1 to use FW control power save (default 1)\n");
>   MODULE_PARM_DESC(debug, "Set debug level (0-5) (default 0)");
> -MODULE_PARM_DESC(disable_watchdog, "Set to 1 to disable the watchdog (default 0)\n");
> +MODULE_PARM_DESC(disable_watchdog,
> +		 "Set to 1 to disable the watchdog (default 0)\n");

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists