netdev - Re: [PATCH v2][Nios2-dev] Altera TSE: Add missing phydev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150102.154500.2104526152897268790.davem@davemloft.net>
Date:	Fri, 02 Jan 2015 15:45:00 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	bkostya@...mail.com
Cc:	nios2-dev@...ts.rocketboards.org, netdev@...r.kernel.org
Subject: Re: [PATCH v2][Nios2-dev] Altera TSE: Add missing phydev

From: Kostya Belezko <bkostya@...mail.com>
Date: Tue, 30 Dec 2014 12:27:09 -0500

> Altera network device doesn't come up after
>  
> ifconfig eth0 down
> ifconfig eth0 up
>  
> The reason behind is clearing priv->phydev during tse_shutdown().
> The phydev is not restored back at tse_open().
> 
> Resubmiting as to follow Tobias Klauser suggestion.
> phy_start/phy_stop are called on each ifup/ifdown and
> phy_disconnect is called once during the module removal. 
> 
> Signed-off-by: Kostya Belezko <bkostya@...mail.com>

I'll apply this, but I'm pretty sure the phy_disconnect() is down
so that the PHY is powered down when the device is not up.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html