netdev - Re: [PATCH net-next] net: skbuff: don't zero tc members when freeing skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150102.160500.1791727400349422767.davem@davemloft.net>
Date:	Fri, 02 Jan 2015 16:05:00 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	fw@...len.de
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: skbuff: don't zero tc members when
 freeing skb

From: Florian Westphal <fw@...len.de>
Date: Wed, 31 Dec 2014 13:33:41 +0100

> Not needed, only four cases:
>  - kfree_skb (or one of its aliases).
>    Don't need to zero, memory will be freed.
>  - kfree_skb_partial and head was stolen:  memory will be freed.
>  - skb_morph:  The skb header fields (including tc ones) will be
>    copied over from the 'to-be-morphed' skb right after
>    skb_release_head_state returns.
>  - skb_segment:  Same as before, all the skb header
>    fields are copied over from the original skb right away.
> 
> Signed-off-by: Florian Westphal <fw@...len.de>

Agreed, applied, thanks Florian.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html