netdev - Re: [PATCH net-next] rhashtable: fix missing header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150104095727.GC15305@casper.infradead.org>
Date:	Sun, 4 Jan 2015 09:57:27 +0000
From:	Thomas Graf <tgraf@...g.ch>
To:	Ying Xue <ying.xue@...driver.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] rhashtable: fix missing header

On 01/04/15 at 05:24pm, Ying Xue wrote:
> On 01/04/2015 05:19 PM, Thomas Graf wrote:
> > On 01/04/15 at 03:25pm, Ying Xue wrote:
> >> Fixup below build error:
> >>
> >> include/linux/rhashtable.h: At top level:
> >> include/linux/rhashtable.h:118:34: error: field ???mutex??? has incomplete type
> > 
> > Just wondering, is this your new code that didn't compile? The code
> > compiled fine for me for the existing users.
> > 
> 
> When I did below patch, I met the build error.

OK, personally I would squash it with that patch then as it's only
needed in combination with the new code.

> http://patchwork.ozlabs.org/patch/425149/
> 
> By the way, please help to review the patch if you have time :)

The convertion looks straight forward although I'm not fully familiar
with the TIPC code. I left a comment with a further optimization idea.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html