netdev - Re: [PATCH iproute2 v2 2/3] ss: Unify packet stats output from netlink and proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150104183218.GA13666@angus-think.lan>
Date:	Sun, 4 Jan 2015 20:32:18 +0200
From:	Vadim Kochan <vadim4j@...il.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	Vadim Kochan <vadim4j@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 v2 2/3] ss: Unify packet stats output from
 netlink and proc

On Sun, Jan 04, 2015 at 10:30:08AM -0800, Stephen Hemminger wrote:
> On Sun,  4 Jan 2015 19:20:54 +0200
> Vadim Kochan <vadim4j@...il.com> wrote:
> 
> > +struct pktstat {
> > +	int type;
> > +	int prot;
> > +	int iface;
> > +	int state;
> > +	int rq;
> > +	int uid;
> > +	int ino;
> > +};
> 
> Rather than copying the original data types, this structure should use the
> correct types that already exist. 
> For example: type is pdiag_type which is __u8 therefore it should be __u8 or uint8_t.
> 
> Likewise uid should be uid_t etc.

Thats good point, but it would be good to do this for all xxxstats
struct's, may be in separated patch ?

Regards,
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html