netdev - Re: [PATCH net-next v2] rhashtable: involve rhashtable_lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150105.163018.658637009804208069.davem@davemloft.net>
Date:	Mon, 05 Jan 2015 16:30:18 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	tgraf@...g.ch
Cc:	ying.xue@...driver.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] rhashtable: involve
 rhashtable_lookup_insert routine

From: Thomas Graf <tgraf@...g.ch>
Date: Mon, 5 Jan 2015 13:05:14 +0000

> On 01/05/15 at 07:33pm, Ying Xue wrote:
>> Involve a new function called rhashtable_lookup_insert() which makes
>> lookup and insertion atomic under bucket lock protection, helping us
>> avoid to introduce an extra lock when we search and insert an object
>> into hash table.
>> 
>> Signed-off-by: Ying Xue <ying.xue@...driver.com>
>> Signed-off-by: Thomas Graf <tgraf@...g.ch>
> 
> Thanks for putting this around so quickly and thanks for testing.
> I think this looks good. You might be able to factor out some code
> from rhashtable_insert() to avoid duplication so we reduce the risk
> of fixing a bug for one function but not the other.

Do you want Ying to do this factoring out now in a v3 of this patch
or in a subsequent patch?

I assume the former since you didn't give your ACK.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html