netdev - [PATCH/RFC rocker-net-next 1/6] net: flow: Cancel innermost nested attribute first

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1420440610-20621-2-git-send-email-simon.horman@netronome.com>
Date:	Mon,  5 Jan 2015 15:50:05 +0900
From:	Simon Horman <simon.horman@...ronome.com>
To:	John Fastabend <john.fastabend@...il.com>
Cc:	netdev@...r.kernel.org, Simon Horman <simon.horman@...ronome.com>
Subject: [PATCH/RFC rocker-net-next 1/6] net: flow: Cancel innermost nested attribute first

Cancel innermost nested attribute first on error when putting flow actions.

Signed-off-by: Simon Horman <simon.horman@...ronome.com>

---

Its unclear to me if this makes any difference.
But it seems more logical to me.
---
 net/core/flow_table.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/flow_table.c b/net/core/flow_table.c
index 542ebb5..2af831e 100644
--- a/net/core/flow_table.c
+++ b/net/core/flow_table.c
@@ -967,8 +967,8 @@ static int net_flow_put_flow_action(struct sk_buff *skb,
 
 		err = net_flow_put_act_types(skb, a[i].args);
 		if (err) {
-			nla_nest_cancel(skb, action);
 			nla_nest_cancel(skb, sigs);
+			nla_nest_cancel(skb, action);
 			return err;
 		}
 		nla_nest_end(skb, sigs);
-- 
2.1.3

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html