netdev - Re: [PATCH/RFC flow-net-next 02/10] net: flow: Add features to tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150105021855.GE15716@vergenet.net>
Date:	Mon, 5 Jan 2015 11:18:58 +0900
From:	Simon Horman <simon.horman@...ronome.com>
To:	Cong Wang <cwang@...pensource.com>
Cc:	John Fastabend <john.r.fastabend@...el.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH/RFC flow-net-next 02/10] net: flow: Add features to tables

On Mon, Dec 29, 2014 at 03:03:39PM -0800, Cong Wang wrote:
> On Sun, Dec 28, 2014 at 6:15 PM, Simon Horman
> <simon.horman@...ronome.com> wrote:
> > +static struct net_flow_table *net_flow_table_get_table(struct net_device *dev,
> > +                                                      int table_uid)
> > +{
> > +       struct net_flow_table **tables;
> > +       int i;
> > +
> > +       tables = net_flow_get_tables(dev);
> > +       if (IS_ERR(tables))
> > +               return ERR_PTR(PTR_ERR(tables));
> 
> Seriously? :)

I was looking for a way to handle the type of tables being different
to the return type of net_flow_table_get_table().

Would you recommend a cast?

		return (struct net_flow_table *)tables;
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html