netdev - Re: [PATCH next] net: netfilter: nfnetlink_cthelper: Remove 'const' and '&' to avoid warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150105114432.GA17895@salvia>
Date:	Mon, 5 Jan 2015 12:44:32 +0100
From:	Pablo Neira Ayuso <pablo@...filter.org>
To:	Chen Gang <gang.chen.5i5j@...il.com>
Cc:	kaber@...sh.net, kadlec@...ckhole.kfki.hu,
	David Miller <davem@...emloft.net>,
	netfilter-devel@...r.kernel.org, coreteam@...filter.org,
	netdev@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH next] net: netfilter: nfnetlink_cthelper: Remove 'const'
 and '&' to avoid warnings

On Wed, Dec 24, 2014 at 11:04:54PM +0800, Chen Gang wrote:
> The related code can be simplified, and also can avoid related warnings
> (with allmodconfig under parisc):
> 
>     CC [M]  net/netfilter/nfnetlink_cthelper.o
>   net/netfilter/nfnetlink_cthelper.c: In function ‘nfnl_cthelper_from_nlattr’:
>   net/netfilter/nfnetlink_cthelper.c:97:9: warning: passing argument 1 o ‘memcpy’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-array-qualifiers]
>     memcpy(&help->data, nla_data(attr), help->helper->data_len);
>            ^
>   In file included from include/linux/string.h:17:0,
>                    from include/uapi/linux/uuid.h:25,
>                    from include/linux/uuid.h:23,
>                    from include/linux/mod_devicetable.h:12,
>                    from ./arch/parisc/include/asm/hardware.h:4,
>                    from ./arch/parisc/include/asm/processor.h:15,
>                    from ./arch/parisc/include/asm/spinlock.h:6,
>                    from ./arch/parisc/include/asm/atomic.h:21,
>                    from include/linux/atomic.h:4,
>                    from ./arch/parisc/include/asm/bitops.h:12,
>                    from include/linux/bitops.h:36,
>                    from include/linux/kernel.h:10,
>                    from include/linux/list.h:8,
>                    from include/linux/module.h:9,
>                    from net/netfilter/nfnetlink_cthelper.c:11:
>   ./arch/parisc/include/asm/string.h:8:8: note: expected ‘void *’ but argument is of type ‘const char (*)[]’
>    void * memcpy(void * dest,const void *src,size_t count);
>           ^

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html