netdev - Re: [PATCH] b43legacy: Remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 06 Jan 2015 12:08:23 -0600
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
CC:	Kalle Valo <kvalo@...rom.com>, linux-wireless@...r.kernel.org,
	b43-dev@...ts.infradead.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] b43legacy: Remove unused function

On 01/06/2015 11:59 AM, Rickard Strandqvist wrote:
> Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>   drivers/net/wireless/b43legacy/radio.c |   19 -------------------
>   drivers/net/wireless/b43legacy/radio.h |    1 -
>   2 files changed, 20 deletions(-)

Acked-by: Larry Finger <Larry.Finger@...inger.net>

Larry

>
> diff --git a/drivers/net/wireless/b43legacy/radio.c b/drivers/net/wireless/b43legacy/radio.c
> index 8961776..9501420 100644
> --- a/drivers/net/wireless/b43legacy/radio.c
> +++ b/drivers/net/wireless/b43legacy/radio.c
> @@ -1743,25 +1743,6 @@ u16 freq_r3A_value(u16 frequency)
>   	return value;
>   }
>
> -void b43legacy_radio_set_tx_iq(struct b43legacy_wldev *dev)
> -{
> -	static const u8 data_high[5] = { 0x00, 0x40, 0x80, 0x90, 0xD0 };
> -	static const u8 data_low[5]  = { 0x00, 0x01, 0x05, 0x06, 0x0A };
> -	u16 tmp = b43legacy_radio_read16(dev, 0x001E);
> -	int i;
> -	int j;
> -
> -	for (i = 0; i < 5; i++) {
> -		for (j = 0; j < 5; j++) {
> -			if (tmp == (data_high[i] | data_low[j])) {
> -				b43legacy_phy_write(dev, 0x0069, (i - j) << 8 |
> -						    0x00C0);
> -				return;
> -			}
> -		}
> -	}
> -}
> -
>   int b43legacy_radio_selectchannel(struct b43legacy_wldev *dev,
>   				  u8 channel,
>   				  int synthetic_pu_workaround)
> diff --git a/drivers/net/wireless/b43legacy/radio.h b/drivers/net/wireless/b43legacy/radio.h
> index bccb3d7..dd2976d 100644
> --- a/drivers/net/wireless/b43legacy/radio.h
> +++ b/drivers/net/wireless/b43legacy/radio.h
> @@ -92,7 +92,6 @@ void b43legacy_nrssi_hw_write(struct b43legacy_wldev *dev, u16 offset, s16 val);
>   void b43legacy_nrssi_hw_update(struct b43legacy_wldev *dev, u16 val);
>   void b43legacy_nrssi_mem_update(struct b43legacy_wldev *dev);
>
> -void b43legacy_radio_set_tx_iq(struct b43legacy_wldev *dev);
>   u16 b43legacy_radio_calibrationvalue(struct b43legacy_wldev *dev);
>
>   #endif /* B43legacy_RADIO_H_ */
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html