netdev - Re: [PATCH] net: ethernet: cpsw: ignore VLAN ID 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150106.141323.2091288413667564444.davem@davemloft.net>
Date:	Tue, 06 Jan 2015 14:13:23 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	balbi@...com
Cc:	netdev@...r.kernel.org, linux-omap@...r.kernel.org,
	stable@...r.kernel.org, mugunthanvnm@...com
Subject: Re: [PATCH] net: ethernet: cpsw: ignore VLAN ID 1

From: Felipe Balbi <balbi@...com>
Date: Tue, 6 Jan 2015 11:43:32 -0600

> CPSW completely hangs if we add, and later remove,
> VLAN ID #1. What happens is that after removing
> VLAN ID #1, no packets will be received by CPSW
> rendering network unusable.
> 
> In order to "fix" the issue, we're returning -EINVAL
> if anybody tries to add VLAN ID #1. While at that,
> also filter out any ID > 4095 because we only have
> 12 bits for VLAN IDs.
> 
> Fixes: 3b72c2f (drivers: net:ethernet: cpsw: add support for VLAN)
> Cc: <stable@...r.kernel.org> # v3.9+
> Cc: Mugunthan V N <mugunthanvnm@...com>
> Tested-by: Schuyler Patton <spatton@...com>
> Signed-off-by: Felipe Balbi <balbi@...com>

You can't just unilaterally make one VLAN ID unusable.

A better way to handle this situation must be found,
and if that means turning off hw VLAN support completely,
that's a much better alternative to this.

I'm not applying this patch, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html