netdev - Re: [PATCH net-next] openvswitch: Do not use private netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 6 Jan 2015 14:28:25 -0800
From:	Pravin Shelar <pshelar@...ira.com>
To:	David Miller <davem@...emloft.net>
Cc:	Daniele Di Proietto <daniele.di.proietto@...il.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] openvswitch: Do not use private netdev_vport fields

On Tue, Jan 6, 2015 at 2:15 PM, Pravin Shelar <pshelar@...ira.com> wrote:
> On Tue, Jan 6, 2015 at 2:02 PM, David Miller <davem@...emloft.net> wrote:
>> From: Pravin Shelar <pshelar@...ira.com>
>> Date: Tue, 6 Jan 2015 13:16:11 -0800
>>
>>> Function return type and function name should be on same line,
>>> otherwise looks good.
>>
>> I disagree, where is the code in the tree that needs this?
>
> Most of function definitions that I have seen are defined like this. I
> was pointing out coding style issue.

About the actual change, I think it is a cleanup. netdev_vport_index()
hides the implementation from datapath.c. I hope Daniele will explain
need for the change.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html