netdev - Re: [PATCH net-next v4] net: Do not call ndo_dflt_fdb_dump if ndo_fdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150105.225241.2023994227710574197.davem@davemloft.net>
Date:	Mon, 05 Jan 2015 22:52:41 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	hubert.sokolowski@...el.com
Cc:	netdev@...r.kernel.org, ray.kinsella@...el.com
Subject: Re: [PATCH net-next v4] net: Do not call ndo_dflt_fdb_dump if
 ndo_fdb_dump is defined

From: Hubert Sokolowski <hubert.sokolowski@...el.com>
Date: Mon, 05 Jan 2015 17:29:21 +0000

> Add checking whether the call to ndo_dflt_fdb_dump is needed.
> It is not expected to call ndo_dflt_fdb_dump unconditionally
> by some drivers (i.e. qlcnic or macvlan) that defines
> own ndo_fdb_dump. Other drivers define own ndo_fdb_dump
> and don't want ndo_dflt_fdb_dump to be called at all.
> At the same time it is desirable to call the default dump
> function on a bridge device.
> Fix attributes that are passed to dev->netdev_ops->ndo_fdb_dump.
> Add extra checking in br_fdb_dump to avoid duplicate entries
> as now filter_dev can be NULL.
> 
> Following tests for filtering have been performed before
> the change and after the patch was applied to make sure
> they are the same and it doesn't break the filtering algorithm.
 ...
> Signed-off-by: Hubert Sokolowski <hubert.sokolowski@...el.com>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html